Fix #4715: Propagate CancellationToken through property injection to prevent hangs #4732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t hangs (#4715) When IAsyncInitializer.InitializeAsync() hangs during property injection in a chained ClassDataSource dependency pattern, the test runner stalls indefinitely because CancellationToken.None is passed through the entire property injection chain. This threads the 5-minute discovery timeout CancellationToken from TestDiscoveryService through PropertyInjector, ObjectLifecycleService, TestBuilder, and TestArgumentRegistrationService so that EnsureInitializedAsync can be cancelled when the timeout fires. Co-Authored-By: Claude Opus 4.6 <[email protected]>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This PR implements a clean solution to the hang issue by threading the cancellation token through the entire property injection chain. The changes are:
The architecture properly leverages .NET's cancellation infrastructure to unblock waiting tests when initialization fails or times out, converting an indefinite hang into a graceful failure with OperationCanceledException. |
This was referenced Feb 10, 2026
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CancellationTokenfromTestDiscoveryService.DiscoverTestsStreamAsyncthrough the entire property injection chain:TestBuilderPipeline→TestBuilder→ObjectLifecycleService→PropertyInjector→EnsureInitializedAsyncIAsyncInitializer.InitializeAsync()hangs during property injection in a chainedClassDataSourcedependency pattern, the timeout now fires and unblocks all waiters viaOperationCanceledException